-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][KERNEL][VARIANT] Add read in delta kernel #3020
Open
richardc-db
wants to merge
24
commits into
delta-io:master
Choose a base branch
from
richardc-db:kernel_read_variant
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7228a30
to
572e307
Compare
…rnt physical storage representations
c06180d
to
6a879b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Adds variant read support and support to make reading variant columns convenient by allowing connectors to read variant column vectors as structs and handling converting the struct column vectors to variant column vectors within the kernel
This is done by introducing a "variant_coalesce" engine function that is used to transform scanned struct column vectors to variant column vectors. When shredding is implemented, "variant_coalesce" can be extended to rebuild shredded variants.
This PR also does the following
How was this patch tested?
Added UTs
Does this PR introduce any user-facing changes?